[quake3-bugzilla] [Bug 4358] Assorted renderer changes patch (VBO, GLSL, "modern" techniques etc.)

[bugzilla-daemon at icculus.org]

https://bugzilla.icculus.org/show_bug.cgi?id=4358

--- Comment #43 from Thilo Schulz <arny at ats.s.bawue.de> 2011-08-01 12:07:02 EDT ---
[17:54:59] <Thilo> there two routes we can go
[17:55:17] <Thilo> one is separate the VBO renderer via ifdeffery and keep the
renderer/ path
[17:55:29] <Timbo> VBO is such a silly term :P
[17:55:33] <Thilo> or separate the renderer out in separate directories
[17:55:47] <Timbo> that's a tiny part of the patch
[17:55:47] <Thilo> both have its advantages/disadvantages
[17:56:09] <Timbo> I would tend to go with ifdeffery
[17:56:32] <Timbo> since both paths are compiled
[17:57:00] <Timbo> my problem with excessive ifdefs is that it encourages dead
code that rarely gets compiled
[17:57:11] <Timbo> so you might break it but you never know about it
[17:57:15] <Thilo> yes
[17:57:19] <Thilo> that's ugly indeed
[17:57:33] <Timbo> and by the time someone figures that out it's had fuckloads
of surrounding changes and doesn't even make sense any more
[17:58:35] <Timbo> it's an awkward thing to deal with really
[17:58:42] <Timbo> this huge renderer patch I mean
[17:58:44] <Thilo> yeah.

Alright. I'll leave it up to you, whether you want to separate the two renderer
paths via #ifdef or two directories.
Via #ifdef would probably be much easier and quicker for you. It may be more
difficult to merge #ifdefs into existing renderers, but once that move is done,
it would probably also be easier to maintain the two paths at the same time if
you change something in the renderer.

-- 
Configure bugmail: https://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.