[quake3-bugzilla] [Bug 3797] /wait accepts negative values

[bugzilla-daemon at icculus.org]

http://bugzilla.icculus.org/show_bug.cgi?id=3797





--- Comment #3 from Ben Millwood <bugzilla at benmachine.co.uk>  2009-03-14 15:26:51 EDT ---
Created an attachment (id=2017)
 --> (http://bugzilla.icculus.org/attachment.cgi?id=2017)
error messages when /wait is used inappropriately

Making cmd_wait unsigned will just mean that
cmd_wait = atoi( Cmd_Argv( 1 ) )
where Cmd_Argv(1) is "-1" will set it to 4294967295, as far as I can tell. You
will still need to identify and handle the negative case, which in my opinion
should be treated as any other invalid input. As I see it, there are three
choices in that regard:
1. ignore, don't wait (same as current for /wait foo)
2. ignore, wait for the default 1 frame (pretend the argument wasn't given)
3. print an error message
Attachment #1889 does 2. which is somewhat inconsistent with other invalid
input (but it's trivial to make it do 1. instead)
The attachment I'm just adding now does 3. and also prints an error when other
invalid input is supplied.

-- 
Configure bugmail: http://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.