[Bug 3414] Overlapping strings with strcpy

bugzilla-daemon at icculus.org bugzilla-daemon at icculus.org
Wed Mar 26 15:42:19 EDT 2008


http://bugzilla.icculus.org/show_bug.cgi?id=3414





------- Comment #4 from tim at ngus.net  2008-03-26 15:42 EDT -------
Revision 1280 made the following change. Is this not what you think is being
tracked here?

Modified: trunk/code/qcommon/q_shared.c
===================================================================
--- trunk/code/qcommon/q_shared.c       2008-03-25 21:59:31 UTC (rev 1279)
+++ trunk/code/qcommon/q_shared.c       2008-03-25 22:06:08 UTC (rev 1280)
@@ -1143,7 +1143,8 @@

                if (!strcmp (key, pkey) )
                {
-                       strcpy (start, s);      // remove this part
+                       memmove(start, s, strlen(s) + 1); // remove this part
+                       
                        return;
                }


-- 
Configure bugmail: http://bugzilla.icculus.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.



More information about the quake3-bugzilla mailing list