[quake2] quake2 improvements and problem

Alexey Dokuchaev danfe at nsu.ru
Sun Mar 27 12:27:15 EST 2005


On Sat, Mar 26, 2005 at 03:20:12PM -0500, Thomas J Fogal wrote:
>    fixes minor code formatting things i noticed (but not all of them)

Actually, you "code formatting things" are quite contrary to nowadays'
most style guidelines:

> -/*
> -
> -key up events are sent even if in console mode
> -
> -*/
> -
> +/* key up events are sent even if in console mode */

Full sentence comments should be coded this way:

/*
 * This is some what long comment.
 */

>  /*
>  ==============================================================================
> -
>  			LINE TYPING INTO THE CONSOLE
> -
>  ==============================================================================
>  */

This is part of original id's comment, and should probably be left
intact.

> +	if(key == 'l' && keydown[K_CTRL]) {

It is actually far more readable to retain space after statement (if,
while, for, switch, return, etc).

> +		Cbuf_AddText ("clear\n");

On the contrary, there are no space after function calls.

> -	if (key == K_PGUP || key == K_KP_PGUP )
> -	{
> +	if(key == K_PGUP || key == K_KP_PGUP) {

Same thing here.

To summarise, when you change things/implement new ones, try to separate
functional changes from style/markup ones (in your diffs, at least).

Thanks!

./danfe



More information about the quake2 mailing list