gettext patch 2

Carles Pina i Estany carles at pina.cat
Tue Feb 5 16:04:41 EST 2008


Hello,

I introduced myself in pyddr-discuss, I don't know if is there somebody
here who is not in pyddr-discuss. I only copy-paste yesterday mail with
some slightly modification.

----------------
Hello all,

I wanted to send a patch with all changes, but I'm feeling that this is
getting too big, so I prefer to send a patch now.
I'm sorry that in this patch I'm doing two things: setting up the
building infrastructure and changing strings.

Note: it is really nice when Pydance talks to me in my mother language,
and I think that this will help us (Catux LUG) a lot to help the good
things about free software :-)

CHANGES
=======
Well, what I have done in the attached patch:

a) In gameselect.py, menudriver.py and pydance.py I added "_" function
in mainly all strings. This is a big change, since pydance is using
user interface strings also for internal use. But should be safe :-)
(but I have to finish these three files and also add the other files!!)

b) New class i18n.py. I was expecting some more lines (it has 2 :-) ).
Even maybe is not needed by module? I will check, by the moment is
working fine.

c) I changed Makefile.posix and Makefile.general to support LOCALESDIR
variable and add po/Makefile task, and also uptrans to update the
translation

d) In ZIPMODS Makefile.general variable I added i18n.py (I needed) and
also fonttheme.py (as Pavel said to me yesterday, new functions... and
was not in the installation -pydance was crashing searching this module)

e) I added po/ directory, with a Makefile and ca.po

It's mainly all, not a hard task but some work searching strings.

COMMENTS
========

I send this patch for:
a) expecting some comments (incorrect things, what to change, I'm bit
confused with Makefiles.*, etc.)

b) because I'm changing mainly all strings, I afraid that somebody will
change some strings next days and we will have conflicts in the commits
--------------

Well, today I also added gettext functions to the other files, I copy
paste the today's mail:
--------------
Hello,

I send a new patch, against SVN version (so only apply this patch).

I added the _("..") in the missing files.

Note: this shouldn't break any English version: since English version is
not get translated to anything. We will test our Catalan version and
then maybe something is broken but I will fix. It will be broken if I
added _("..") in some place but not in another place and pydance is
comparing it.

And I'm sure that I forgot to add _("..") to some strings (some I didn't
know if was internal strings or external, etc.). I will also add when I
will see the problems :-) (next days, when I will have a catalan
version)

Thanks,
--------------

Thanks again,

-- 
Carles Pina i Estany		GPG id: 0x8CBDAE64
	http://pinux.info	Manresa - Barcelona
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gettext2.patch.gz
Type: application/octet-stream
Size: 11979 bytes
Desc: not available
URL: <http://icculus.org/pipermail/pyddr-devel/attachments/20080205/7affda32/attachment.obj>


More information about the pyddr-devel mailing list