[pyddr-devel] Added level sorting to songselect.py

Frank Foeth foeth01 at orange.nl
Sun Jan 21 10:36:23 EST 2007


Hello Pavel,

> Thanks! I, for one, think that it's a useful feature. Though, in the
> future, could you please use 'svn diff' to generate the patch? It makes
> it much easier to apply, especially if it affects multiple files.
Thank you for liking the idea. As you might have guessed I'm not used
quite at home with svn, so thanks for the advice. Using diff/patch
proved to be a pain. I trust this will be better.

> I've tried the patch out as it is. Unfortunately, it appears to die if
> the folder being viewed contains nonstandard difficulty level names
> (which show up in some unofficial steps), so I haven't been able to test
> it. I've attached the file with the traceback.
Yep, it should. I'll ban anything nonstandard to the end of the 
displayed list.

> > Known problems in "level" sorting: 
> > 1. ...
> 
> Please correct me if I am misunderstanding the problem, but what about
> ending up in the folder of the level of the difficulty selected at the
> time the mode was changed?
You are right. The main problem is that I still don't quite grasp how
difficulty levels are indicated and transported to the dance performing
section. I did not use it sofar, so I could live with it. I have an idea
that might work to figure this out, if not I'll post the question.
Unfortunately, I'll have to go with the first player's difficulty
selection though, I can't please both, but then level sorting is most
usefull in single player mode anyway.

> > 2. ...
> > 3. ...
> > 
> > The reason I did not do 2. and 3. yet is to limit the patch to one
> > file. 
> 
> Don't worry about that --- make whatever changes are needed to get this
> right, and then use 'svn diff' to make the patch.
I'll give it a go, hopefully tomorrow. I hope to have things ready some
time next week, depends on how difficult sorting out 1. is.

Thanks for the comments and advice,

Yours,
Frank





More information about the pyddr-devel mailing list