[pyddr-devel] Level an Difficulty sorting in songselect

Frank Foeth foeth01 at orange.nl
Wed Feb 14 09:01:25 EST 2007


Hi Pavel,

Just a patch this time. Still thinking about comments on chosen
structure.

> > > Remarks patch feb 12:
> > > 1. It crashes when selecting CONFIRM to perform a dance in songselect.
Sorted
> > > 2. Limited choices in the level and difficulty sorting modes (i.e. RIGHT
> > > and LEFT have no effect.)
Untouched

> > > 3. Multiple use of _song... where _song... contains either song or dance
> > > data which makes the code ambiguous, maybe replace with _item... 
Done

> > > 4. SongItemDisplay and DanceItemDisplay both share almost all
> > > parameters, but this is not enforced by AbstractItemDisplay.
Trivial, but I did it anyway. Sorry for the schoolmaster, hope not to
repeat it. 

5. Repaired bug in rank sorting, it seems that game was undefined.

Hopefully no oversights,

Yours,

Frank
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dancesort.patch
Type: text/x-patch
Size: 24326 bytes
Desc: not available
URL: <http://icculus.org/pipermail/pyddr-devel/attachments/20070214/4468c6b8/attachment.bin>


More information about the pyddr-devel mailing list