Patch: Improvement to between-song options menu, DWI #FILE handling, and a bug fix.

Pavel Nikolai Krivitsky pavel at krivitsky.name
Sun Feb 20 03:16:57 EST 2005


This patch does three independent things, so I attached both a one-file
version of it (all_in_one.diff), and the same changes as three separate
patches. Do NOT attempt to apply all four. All patches are against the
Subversion repository revision 1028.


between-song_opts.diff:
When the options menu is brought up between songs (in Nonstop and
Endless modes), the options that are not changeable between songs are
not displayed, rather than being displayed but silently ignored.


DWI_FILE_find.diff:
When parsing a DWI file, this patch attempts to use the
previously-ignored information in the #FILE tag, when other means to
locate the audio file fail. These tags are platform-dependent and assume
that there is only one song directory, so this patch tries to deduce the
file to which they could be referring. As a result, it is quite
sensitive to the directory layout, but should work reasonably well on
most systems.

So far, it works on the "Edit Data" mixes downloaded from DDRUK, on my
Debian system. I am interested in hearing whether it works for anyone
else and on other platforms.


bug_fixes.diff:
Fixes pydance dying when one tries to play the "Likes" and "Dislikes"
autogenerated courses. Also fixes an unrelated grammatical error in a
comment.

              Let me know if there are any problems,
              Pavel Krivitsky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: all_in_one.diff
Type: text/x-patch
Size: 10828 bytes
Desc: not available
URL: <http://icculus.org/pipermail/pyddr-devel/attachments/20050220/504b41ce/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: between-song_opts.diff
Type: text/x-patch
Size: 6315 bytes
Desc: not available
URL: <http://icculus.org/pipermail/pyddr-devel/attachments/20050220/504b41ce/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DWI_FILE_find.diff
Type: text/x-patch
Size: 2773 bytes
Desc: not available
URL: <http://icculus.org/pipermail/pyddr-devel/attachments/20050220/504b41ce/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_fixes.diff
Type: text/x-patch
Size: 1740 bytes
Desc: not available
URL: <http://icculus.org/pipermail/pyddr-devel/attachments/20050220/504b41ce/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://icculus.org/pipermail/pyddr-devel/attachments/20050220/504b41ce/attachment.pgp>


More information about the pyddr-devel mailing list