[physfs] Build issues with physfs 2.0 / HG
Brad Smith
brad at comstyle.com
Thu Aug 2 03:22:28 EDT 2012
On Thu, Aug 02, 2012 at 03:06:32AM -0400, Ryan C. Gordon wrote:
>
> >to check for __unix__ || unix.
>
> Fixed now.
>
> >HG has also added a section for BSD OS's but it checks for the
> >symbol BSD which is only defined if sys/param.h is included
>
> I ended up plugging in the common BSDs instead.
>
> >The other issue with 2.0 was with the __PHYSFS_platformGetThreadID()
> >function failing to build as is. This commit needs to be back ported
> >to the 2.0 branch..
>
> Done.
>
> Let me know if this gets you running.
Also I have a diff like so to get the readline support
to build. It checks for a libhistory which we don't
have but it doesn't actually use said library.
diff -r 184697ee7a77 CMakeLists.txt
--- a/CMakeLists.txt Thu Aug 02 02:57:55 2012 -0400
+++ b/CMakeLists.txt Thu Aug 02 03:19:59 2012 -0400
@@ -308,13 +308,12 @@
FIND_LIBRARY(CURSES_LIBRARY NAMES curses ncurses)
SET(CMAKE_REQUIRED_LIBRARIES ${CURSES_LIBRARY})
FIND_LIBRARY(READLINE_LIBRARY readline)
- FIND_LIBRARY(HISTORY_LIBRARY history)
- IF(READLINE_LIBRARY AND HISTORY_LIBRARY)
+ IF(READLINE_LIBRARY)
SET(HAVE_SYSTEM_READLINE TRUE)
SET(TEST_PHYSFS_LIBS ${TEST_PHYSFS_LIBS} ${READLINE_LIBRARY} ${CURSES_LIBRARY})
INCLUDE_DIRECTORIES(${READLINE_H} ${HISTORY_H})
ADD_DEFINITIONS(-DPHYSFS_HAVE_READLINE=1)
- ENDIF(READLINE_LIBRARY AND HISTORY_LIBRARY)
+ ENDIF(READLINE_LIBRARY)
ENDIF(READLINE_H AND HISTORY_H)
ADD_EXECUTABLE(test_physfs test/test_physfs.c)
TARGET_LINK_LIBRARIES(test_physfs ${PHYSFS_LIB_TARGET} ${TEST_PHYSFS_LIBS} ${OTHER_LDFLAGS})
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
More information about the physfs
mailing list