[physfs] Re: visibility warning

[Dennis Schridde]

Am Samstag, 8. März 2008 18:21:39 schrieb Dennis Schridde:
> Am Samstag, 8. März 2008 16:21:12 schrieb Indy Sams:
> > Hello Dennis,
> >
> >       Maybe because you are building static??? I've never tried
> >       setting visibility flags on anything but shared objects (.so).
>
> (a) I did not set -fvisibility=hidden myself... No idea where that comes
> from...
> (b) Visibility only affects shared objects? Must be because binaries don't
> export any symbols like that, I guess... Makes sense. ;)
I worked around this by disabling visibility whenever static builds are 
requested. This fix should probably be extended to disable visibility only 
for the static build...

Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt      (revision 930)
+++ CMakeLists.txt      (working copy)
@@ -57,9 +57,9 @@
         #endif
     " PHYSFS_IS_GCC4)

-    IF(PHYSFS_IS_GCC4)
+    IF(PHYSFS_IS_GCC4 AND NOT PHYSFS_BUILD_STATIC)
         ADD_DEFINITIONS(-fvisibility=hidden)
-    ENDIF(PHYSFS_IS_GCC4)
+    ENDIF(PHYSFS_IS_GCC4 AND NOT PHYSFS_BUILD_STATIC)
 ENDIF(CMAKE_COMPILER_IS_GNUCC)

 IF(MSVC)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://icculus.org/pipermail/physfs/attachments/20080308/14e030b1/attachment.pgp>