r878 - in trunk: . archivers

DONOTREPLY at icculus.org DONOTREPLY at icculus.org
Wed Mar 28 13:29:53 EDT 2007


Author: icculus
Date: 2007-03-28 13:29:52 -0400 (Wed, 28 Mar 2007)
New Revision: 878

Modified:
   trunk/CHANGELOG.txt
   trunk/archivers/grp.c
   trunk/archivers/hog.c
   trunk/archivers/mvl.c
Log:
Logic bug in MVL/HOG/GRP archivers: these archives never contain subdirs...but they
 only enumerated their files when looking in a directory other than the root,
 instead of enumerating only for the root. Thanks to Chris Taylor for the
 catch.



Modified: trunk/CHANGELOG.txt
===================================================================
--- trunk/CHANGELOG.txt	2007-03-26 07:53:43 UTC (rev 877)
+++ trunk/CHANGELOG.txt	2007-03-28 17:29:52 UTC (rev 878)
@@ -2,6 +2,9 @@
  * CHANGELOG.
  */
 
+03282007 - Logic bug in MVL/HOG/GRP archivers: only enumerated files when
+           looking in a directory other than the root, instead of enumerating
+           only for the root (thanks, Chris!).
 03262007 - Tons of Unicode work in windows.c ... should now use UCS-2 on
            NT/XP/Vista/etc versions of the OS, and fallback to "ANSI" versions
            for 95/98/ME, tapdancing around the system codepage if it has to.

Modified: trunk/archivers/grp.c
===================================================================
--- trunk/archivers/grp.c	2007-03-26 07:53:43 UTC (rev 877)
+++ trunk/archivers/grp.c	2007-03-28 17:29:52 UTC (rev 878)
@@ -295,7 +295,7 @@
                                const char *origdir, void *callbackdata)
 {
     /* no directories in GRP files. */
-    if (*dname != '\0')
+    if (*dname == '\0')
     {
         GRPinfo *info = (GRPinfo *) opaque;
         GRPentry *entry = info->entries;

Modified: trunk/archivers/hog.c
===================================================================
--- trunk/archivers/hog.c	2007-03-26 07:53:43 UTC (rev 877)
+++ trunk/archivers/hog.c	2007-03-28 17:29:52 UTC (rev 878)
@@ -334,7 +334,7 @@
                                const char *origdir, void *callbackdata)
 {
     /* no directories in HOG files. */
-    if (*dname != '\0')
+    if (*dname == '\0')
     {
         HOGinfo *info = (HOGinfo *) opaque;
         HOGentry *entry = info->entries;

Modified: trunk/archivers/mvl.c
===================================================================
--- trunk/archivers/mvl.c	2007-03-26 07:53:43 UTC (rev 877)
+++ trunk/archivers/mvl.c	2007-03-28 17:29:52 UTC (rev 878)
@@ -291,7 +291,7 @@
                                const char *origdir, void *callbackdata)
 {
     /* no directories in MVL files. */
-    if (*dname != '\0')
+    if (*dname == '\0')
     {
         MVLinfo *info = ((MVLinfo *) opaque);
         MVLentry *entry = info->entries;




More information about the physfs-commits mailing list