r865 - trunk/platform

DONOTREPLY at icculus.org DONOTREPLY at icculus.org
Sat Mar 24 01:13:55 EDT 2007


Author: icculus
Date: 2007-03-24 01:13:54 -0400 (Sat, 24 Mar 2007)
New Revision: 865

Modified:
   trunk/platform/pocketpc.c
   trunk/platform/windows.c
Log:
Added some FIXME comments.


Modified: trunk/platform/pocketpc.c
===================================================================
--- trunk/platform/pocketpc.c	2007-03-24 03:54:58 UTC (rev 864)
+++ trunk/platform/pocketpc.c	2007-03-24 05:13:54 UTC (rev 865)
@@ -561,6 +561,11 @@
 } /* __PHYSFS_platformDelete */
 
 
+/*
+ * !!! FIXME: why aren't we using Critical Sections instead of Mutexes?
+ * !!! FIXME:  mutexes on Windows are for cross-process sync. CritSects are
+ * !!! FIXME:  mutexes for threads in a single process and are faster.
+ */
 void *__PHYSFS_platformCreateMutex(void)
 {
     return((void *) CreateMutex(NULL, FALSE, NULL));

Modified: trunk/platform/windows.c
===================================================================
--- trunk/platform/windows.c	2007-03-24 03:54:58 UTC (rev 864)
+++ trunk/platform/windows.c	2007-03-24 05:13:54 UTC (rev 865)
@@ -903,6 +903,11 @@
 } /* __PHYSFS_platformDelete */
 
 
+/*
+ * !!! FIXME: why aren't we using Critical Sections instead of Mutexes?
+ * !!! FIXME:  mutexes on Windows are for cross-process sync. CritSects are
+ * !!! FIXME:  mutexes for threads in a single process and are faster.
+ */
 void *__PHYSFS_platformCreateMutex(void)
 {
     return((void *) CreateMutex(NULL, FALSE, NULL));




More information about the physfs-commits mailing list