[openbox] "Enter" key in menu

Alexey Korop akorop at gmail.com
Tue Nov 9 06:32:33 EST 2010

Dana Jansens wrote on 09.11.2010 03:24:
>>     Sorry, but Your patch introduced a new bug. Now after selection a submenu by keyboard accelerator, a child menu is expanded but not activated.
> Thanks, fixed this.
     Thanks, it works. But Your corrections are very hostile to the 
submenu with a default choice. The Right and Enter keys processing are 
combined but must be different; The Enter key and the accelerator 
processing are separated (for the submenu) but may be combined; 
selection of the submenu moved to the key press processing but must be 
executed in the key release processing due to possibility of the default 
item execution.
      My patch that improve the submenus with default choice is based on 
Your final code state but it largely returns the old code, excuse me.

>> I have already prepared a patch which adds long awaiting submenu with default choice, with different works of this keys ("Enter" execute a default item, "Right" expand a submenu). I held this big patch because I wanted to first resolve the small issue with Enter, which affects the same part of the program text.
> How would you run such a default action without using the keyboard ?
      Description are here: 
http://bugzilla.icculus.org/show_bug.cgi?id=4795 or in my letter titled 
"Submenus with default choice improved"

Yours truly Alexey

More information about the openbox mailing list