[openbox] window.handle.width & beta2

[Chandler Carruth]

On Tue, 2003-09-09 at 18:47, Andy wrote:
> Chandler Carruth wrote:
> > On Tue, 2003-09-09 at 16:34, Andy wrote:
> > 
> >>After glancing at the source of theme.c, lines 153 to 158:
> >>
> >>     if (!read_int(db, "window.handle.width", &theme->handle_height))
> >>         theme->handle_height = 6;
> >>     if (!theme->handle_height)
> >>         theme->show_handle = FALSE;
> >>     if (theme->handle_height <= 0 || theme->handle_height > 100)
> >>         theme->handle_height = 6;
> >>
> >>It seems as though in order to make the handle disappear or have a 
> >>height of 0, you just leave it out, correct? However this doesn't seem 
> >>to work.
> >>
> >>Not being especially versed in C I'm not sure about this, but it looks 
> >>to me as though the second if-then statement will never come around 
> >>since the first sets a value if one isn't defined in the themerc.
> > 
> > 
> > this is not an if...else statement... when the "if" statement is not
> > true, it simply doesn't do the thing in the if statement... the next
> > statement is still evaluated...
> > 
> > so setting the height to 0 in the themerc will cause "show_handle" to be
> > false, and "handle_height" to be 6.
> > 
> 
> Well, the fact remains that neither setting window.handle.width to 0 or 
> just not defining it at all doesn't make the handle disappear.
> 
> -Andy
> 
> 

which it would seem to me is a bug in the renderer not paying attention
to the show_handle flag, and perhaps you should put it on bugzilla.

-c