[openbox] alpha4 compile problem on Intel Sunos 5.8

Christian von Mueffling cvm at aiss.de
Tue Aug 12 08:10:43 EDT 2003


On Tue, Aug 12, 2003 at 06:13:22AM -0400, Ben Jansens wrote:

> > *** ./kernel/dispatch.h.orig	Mon Aug 11 14:20:30 2003
> > --- ./kernel/dispatch.h	Mon Aug 11 14:21:10 2003
> > ***************
> > *** 1,9 ****
> >   #ifndef __dispatch_h
> >   #define __dispatch_h
> >   
> > - #include "misc.h"
> > - 
> >   #include <X11/Xlib.h>
> >   
> >   struct _ObClient;
> >   
> > --- 1,9 ----
> >   #ifndef __dispatch_h
> >   #define __dispatch_h
> >   
> >   #include <X11/Xlib.h>
> > + #include <X11/Xutil.h>
> > + #include "misc.h"
> >   
> >   struct _ObClient;
> 
> This one seems.. odd to me. The only thing used in that header is
> XEvent.  Which should not require Xutil.h. This feels like a blanket
> include that belongs in other headers where Xutil stuff is actually
> used. Can you confirm this for me (and tell me where Xutil.h should
> really go for solaris?)

In fact it is sufficient if it is included in 'dispatch.c', before the
inclusion of 'extensions.h'. Otherwise I get the following error:

------------------------------------------------------------------------------
In file included from kernel/dispatch.h:6,
                 from kernel/dispatch.c:1:
/usr/openwin/include/X11/Xlib.h:32: warning: ignoring #pragma ident 
In file included from kernel/extensions.h:11,
                 from kernel/dispatch.c:3:
/usr/openwin/include/X11/extensions/shape.h:98: parse error before "Region"
------------------------------------------------------------------------------

Seems that extensions.h use 'Region' and this seems to be defined in
'Xutil.h'.

-- 
chris



More information about the openbox mailing list