[obdgpslogger] obsgui build errors with fltk-1.3.0

[Maciej Grela]

Hi,

I'm a pretty new user of obdgpslogger and I've been developing an
ebuild file for it for Gentoo. When I've tried to compile obdgpslogger
gui it failed with the following error:

Scanning dependencies of target obdgui
[ 46%] Building CXX object src/gui/CMakeFiles/obdgui.dir/guessdevs.cpp.o
[ 48%] Building CXX object src/gui/CMakeFiles/obdgui.dir/loggerhandler.cpp.o
[ 50%] Building CXX object src/gui/CMakeFiles/obdgui.dir/obdgui.cpp.o
Linking CXX executable ../../../bin/obdgui
libckobdfl.a(maindisplay.cxx.o): In function `OBDUI::~OBDUI()':
maindisplay.cxx:(.text+0x17fb): undefined reference to
`obdconvertwindow::~obdconvertwindow()'
collect2: ld returned 1 exit status
make[2]: *** [../bin/obdgui] Błąd 1
make[1]: *** [src/gui/CMakeFiles/obdgui.dir/all] Błąd 2
make: *** [all] Błąd 2

I've investigated this a bit and reached this thread:

http://www.mail-archive.com/fltk@easysw.com/msg11338.html

The conclusion is that fltk-1.3.0 (which I've been using) doesn't
generate a destructor body in the .cxx file if it's empty in the
convertwindow.fl, it does however declare the destructor in the header
file causing compiler confusion. The fix that I have tested to work
with fltk-1.3.0 is to apply the following patch:

diff -urp obdgpslogger-0.16.orig/src/gui/convertwindow.fl
obdgpslogger-0.16/src/gui/convertwindow.fl
--- obdgpslogger-0.16.orig/src/gui/convertwindow.fl	2010-05-02
01:24:44.000000000 +0200
+++ obdgpslogger-0.16/src/gui/convertwindow.fl	2011-09-18
16:35:23.408642135 +0200
@@ -102,8 +102,6 @@ if(0 < f.count())
     }
     code {mMainui = obdui;} {}
   }
-  Function {~obdconvertwindow()} {open
-  } {}
   decl {OBDUI *mMainui;} {}
   decl {enum obd_convert_type mConvertType;} {}
   Function {show()} {open

Unfortunately, I have not checked yet if it still works with fltk-1.1
but I'm interested what do you think about this problem and my fix and
will you consider applying the patch.

Best regards,
Maciej Grela