[obdgpslogger] Changing default columns doesn't change OBDSIM

[Robert Konigsberg]

Thanks for this patch. I may apply it Saturday.

By the way, I have made an adjustment from using Mac / Macbook Pro to a
netbook because a) macs shut down when you close the lid and b) damn do they
get hot on your lap.

A plug sounds great but I'm running out of time.

I bet you could get quite a lot of generalization done by switching to --
ahem -- Java.

But I think in the end, I'll dump the visualizations, and merely move to
headless logging. I can always make sure it's logging just by watching the
OBDProLogger's flashing lights.

-Rob

On Wed, Jul 14, 2010 at 5:44 PM, Gary Briggs <chunky at icculus.org> wrote:

> On Wed, Jul 14, 2010 at 04:22:00PM -0400, Robert Konigsberg wrote:
> > BTW I have updated the GUI, and I'm sure I updated it appropriately, to
> show
> > more columns. I just need to get that data from somewhere, and now that
> > somewhere is probably just my car. I'll have to test it later tonight.
>
> This diff should make cycle report values for PIDs up to 0x59 [although it
> will
> probably return NO DATA for the top few, since I haven't filled the info
> on those PIDs yet]
>
> Gary
>
> Index: src/sim/generators/cycle/gen_cycle.c
> ===================================================================
> --- src/sim/generators/cycle/gen_cycle.c        (revision 488)
> +++ src/sim/generators/cycle/gen_cycle.c        (working copy)
> @@ -95,15 +95,15 @@
>
>        struct cycle_gen *g = (struct cycle_gen *)gen;
>
> -       if(0x00 == PID) {
> +       if(0x00 == PID || 0x20 == PID || 0x40 == PID) {
>                *A = 0xFF;
>                *B = 0xFF;
>                *C = 0xFF;
> -               *D = 0xFE;
> +               *D = 0x40==PID?0xFE:0xFF;
>                return 4;
>        }
>
> -       if(0x20 <= PID) return 0;
> +       if(0x60 <= PID) return 0;
>
>        struct timeval newtime;
>        gettimeofday(&newtime, NULL);
>
> _______________________________________________
> obdgpslogger mailing list
> obdgpslogger at icculus.org
> http://icculus.org/mailman/listinfo/obdgpslogger
>



-- 
Robert Konigsberg
konigsberg at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://icculus.org/pipermail/obdgpslogger/attachments/20100716/6542923f/attachment.htm>