[mojosetup] Fix gtk2 detection in cmake

[Steffen Pankratz]

On Tue, 27 Oct 2015 14:29:40 +0100
djcj <djcj at gmx.de> wrote:

Hi

> Here's a patch to fix the gtk2 detection in cmake.

I also send a patch, actually two patches.
I did not CC the mailing-list though, I send it directly to Ryan.

Here is my original mail:

I fixed that by replacing the hard-coded includes with CMake functionality.
The FindGTK2.cmake module was first introduced with CMake 2.8.0.

I have two versions of the patch:

Version 1:
https://bitbucket.org/kratz00/mojosetup/commits/3768f42682f794e842d5dd33d58d6e6453620555
from objdump -p libmojosetupgui_gtkplus2.so

  NEEDED               libglib-2.0.so.0
  NEEDED               libgobject-2.0.so.0
  NEEDED               libgdk_pixbuf-2.0.so.0
  NEEDED               libgdk-x11-2.0.so.0
  NEEDED               libgtk-x11-2.0.so.0
  NEEDED               libc.so.6

Version 2:
https://bitbucket.org/kratz00/mojosetup/commits/3768f42682f794e842d5dd33d58d6e6453620555
from objdump -p libmojosetupgui_gtkplus2.so
  NEEDED               libgtk-x11-2.0.so.0
  NEEDED               libc.so.6

The difference is obvious and I think version 2 is more portable,
as the dynamic linker/loader will take care of the library dependencies at run time.


Regards
-Steffen

-- 
Hermes powered by Manjaro Linux (Linux 4.2.4)

Best regards, Steffen Pankratz.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://icculus.org/pipermail/mojosetup/attachments/20151027/7e13cffe/attachment.sig>