[mojosetup] CMake curses stuff [diff attached]

[Steffen Pankratz]

On Mon, 1 Mar 2010 12:00:36 -0500
Gary Briggs <chunky at icculus.org> wrote:

> On Sun, Feb 28, 2010 at 11:50:02PM -0800, Ryan C. Gordon wrote:
> > 
> > >So I patched FindCurses.cmake and put it into a cmakemodules subdir of
> > >mojosetup, and moved the path appropriately.
> > 
> > I just pushed these changes to my repository. Please sync up and verify 
> > it still works for you.

I can confirm, it works for me too.
Well done Gary.


> # !!! FIXME: correct this to new policy and bump minimum cmake requirement.

The only line in CMakeLists.txt which triggers this policy is:

ADD_DEFINITIONS(-DAPPREV="${MOJOSETUP_VERSION}")

I did some testing:

old behavior
-DAPPREV="hg-750:38f5bc09d1ee"
mojosetup, revision hg-750:38f5bc09d1ee, built Mar  1 2010 20:34:11, by
GCC 4.1.2

new behavior
-DAPPREV=\"hg-750:38f5bc09d1ee\
mojosetup, revision "hg-750:38f5bc09d1ee", built Mar  1 2010 20:35:42,
by GCC 4.1.2

policy workaround removed, min cmake req set to 2.6 (new behavior is default in 2.6)
-DAPPREV=\"hg-750:38f5bc09d1ee\"
mojosetup, revision "hg-750:38f5bc09d1ee", built Mar  1 2010 20:29:10, by GCC 4.1.2

policy workaround removed, and "" removed (ADD_DEFINITIONS(-DAPPREV=${MOJOSETUP_VERSION}))
-DAPPREV=hg-750:38f5bc09d1ee
mojosetup, revision hg-750:38f5bc09d1ee, built Mar  1 2010 20:37:25, by
GCC 4.1.2


So whats the big deal?
Worth reading:
http://www.vtk.org/Wiki/CMake_Policies#Fixing_an_Interface_Breaks_Work-Arounds


-- 
Hermes powered by LFS SVN-20070420 (Linux 2.6.33)

Best regards, Steffen Pankratz.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://icculus.org/pipermail/mojosetup/attachments/20100301/97159723/attachment.pgp>