r385 - trunk

[DONOTREPLY at icculus.org]

Author: icculus
Date: 2007-12-05 06:12:35 -0500 (Wed, 05 Dec 2007)
New Revision: 385

Modified:
   trunk/gui_stdio.c
Log:
Hmm...popen() isn't really reliable for the pager code:

  - If a program doesn't exist, it'll report success.
  - If a program closes the stream without paging it all, fwrite()
    will report failure.
  - If we roll our own with fork()/exec(), we have to parse any potential
    command lines.

It's a mess. You only get dumb_pager() for now.  :/



Modified: trunk/gui_stdio.c
===================================================================
--- trunk/gui_stdio.c	2007-12-05 10:37:09 UTC (rev 384)
+++ trunk/gui_stdio.c	2007-12-05 11:12:35 UTC (rev 385)
@@ -355,7 +355,8 @@
     int retval = -1;
     boolean failed = true;
 
-    #if PLATFORM_UNIX
+    // !!! FIXME: popen() isn't reliable.
+    #if 0  //PLATFORM_UNIX
     const size_t namelen = strlen(name);
     const char *programs[] = { getenv("PAGER"), "more", "less -M", "less" };
     int i = 0;