[Gtkradiant] [Bug 970] add JKII and JA game packs for OSX setup

gtkradiant@zerowing.idsoftware.com gtkradiant@zerowing.idsoftware.com
Tue, 30 Dec 2003 03:33:16 -0600


ttimo@idsoftware.com changed:

           What    |Removed                     |Added
            Summary|add JKII and JA support to  |add JKII and JA game packs
                   |OSX setup                   |for OSX setup

------- Additional Comments From ttimo@idsoftware.com  2003-12-30 03:33 -------
That's a good start. Several issues with that code though:

- It was not made against the current 1.4 source. You should use the svn client
to fetch the 1.4 source and work from there, not work from the 1.3.13 tarball
for OSX. (those are release files, no good for developers)

- when you're working with the source using SVN, you can send 'svn diff'
patches, which are much easier to manipulate

- need to point to branches/1.4 in repository path for svn checkout

- JA and JKII packs need to be on only for OSX setup, and not for Linux setup

Otherwise it's a step in the right direction: add fetching of the additional SVN
modules (be sure to rework the SVN URL in the osx_setup.py script to point to
branches/1.4 for each module!), and add the game pack entries in .xml.in file

If I get a patch that works against 1.4 source I'll give it another look..