[Gtkradiant] CVS: bug 556, invisible caulk/clip faces selected in camera

Timothee Besset gtkradiant@zerowing.idsoftware.com
Fri, 27 Sep 2002 15:59:51 -0500


This is a mixed plain/HTML MIME encoded message.

--10331603918474
Content-Type: text/plain

User   : timo
Branch : Stable-1_2
Root   : zerowing:/cvs
Date   : 2002/09/27  15:59:36

bug 556, invisible caulk/clip faces selected in camera

--

  GtkRadiant/docs/developer/CHANGES
    1.255.2.108 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.255.2.108
    diff :
      	- more CORERADIANTDIR cleanup (q3data)
      	- http://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=602
      		added cascading to the entity submenu (doesn't cascade the main menu, only the sub ones, NPC_* for instance)
    + 	- http://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=556
    + 		with clip and caulk filtered out, won't be selected anymore in camera view (i.e. selecting invisible faces)
    + 		added SF_CAMERA to the flags in the selection process
    + 		cleanup up various ugly syntaxes in the selection code:
    + 		  don't ever do if (flags == SF_SINGLEFACE) on a bitmask and assert that the other flags will always be NULL
    + 			don't do arithmetic on bitmasks:
    + 				if ( (flags & SF_ENTITIES_FIRST) && t.brush == NULL)
    +           return Test_Ray (origin, dir, flags - SF_ENTITIES_FIRST);
    +         is WRONG
    + 				using flags & ~SF_ENTITIES_FIRST is the appropriate way
      
      23/09/2002
        Riant

8 files modified :

  GtkRadiant/docs/developer/CHANGES
    1.255.2.108 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.255.2.108
    1.255.2.107 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.255.2.107
    diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES.diff?r1=1.255.2.107&r2=1.255.2.108

  GtkRadiant/radiant/brush.cpp
    1.30.2.7 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.cpp?rev=1.30.2.7
    1.30.2.6 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.cpp?rev=1.30.2.6
    diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.cpp.diff?r1=1.30.2.6&r2=1.30.2.7

  GtkRadiant/radiant/brush.h
    1.12.2.1 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.h?rev=1.12.2.1
    1.12 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.h?rev=1.12
    diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.h.diff?r1=1.12&r2=1.12.2.1

  GtkRadiant/radiant/camwindow.cpp
    1.17.6.9 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/camwindow.cpp?rev=1.17.6.9
    1.17.6.8 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/camwindow.cpp?rev=1.17.6.8
    diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/camwindow.cpp.diff?r1=1.17.6.8&r2=1.17.6.9

  GtkRadiant/radiant/drag.cpp
    1.7.2.3 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/drag.cpp?rev=1.7.2.3
    1.7.2.2 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/drag.cpp?rev=1.7.2.2
    diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/drag.cpp.diff?r1=1.7.2.2&r2=1.7.2.3

  GtkRadiant/radiant/qe3.h
    1.49.2.8 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/qe3.h?rev=1.49.2.8
    1.49.2.7 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/qe3.h?rev=1.49.2.7
    diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/qe3.h.diff?r1=1.49.2.7&r2=1.49.2.8

  GtkRadiant/radiant/select.cpp
    1.19.2.5 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.cpp?rev=1.19.2.5
    1.19.2.4 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.cpp?rev=1.19.2.4
    diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.cpp.diff?r1=1.19.2.4&r2=1.19.2.5

  GtkRadiant/radiant/select.h
    1.8.14.1 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.h?rev=1.8.14.1
    1.8 : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.h?rev=1.8
    diff : http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.h.diff?r1=1.8&r2=1.8.14.1


--10331603918474
Content-Type: text/html

<html>
<head><title>CVS report</title></head>
<body bgcolor="#ffffff" text="#000000">

<table border=0 width="100%" cellspacing=0 cellpadding=0>
 <tr>
<td align=left><b>Commit from <i>timo</i> on branch <i>Stable-1_2</i></b></td>
  <td align=right valign=bottom>2002/09/27  &nbsp; 15:59:36</td>
 </tr>
</table>
<hr width="100%" size=2 noshade><br>

<code>
bug 556, invisible caulk/clip faces selected in camera<br>
</code>
<hr width="100%" size=2 noshade><br>
<code>
<b>GtkRadiant/docs/developer/CHANGES</b>
<pre>  	- more CORERADIANTDIR cleanup (q3data)
  	- http://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=602
  		added cascading to the entity submenu (doesn't cascade the main menu, only the sub ones, NPC_* for instance)
+ 	- http://zerowing.idsoftware.com/bugzilla/show_bug.cgi?id=556
+ 		with clip and caulk filtered out, won't be selected anymore in camera view (i.e. selecting invisible faces)
+ 		added SF_CAMERA to the flags in the selection process
+ 		cleanup up various ugly syntaxes in the selection code:
+ 		  don't ever do if (flags == SF_SINGLEFACE) on a bitmask and assert that the other flags will always be NULL
+ 			don't do arithmetic on bitmasks:
+ 				if ( (flags & SF_ENTITIES_FIRST) && t.brush == NULL)
+           return Test_Ray (origin, dir, flags - SF_ENTITIES_FIRST);
+         is WRONG
+ 				using flags & ~SF_ENTITIES_FIRST is the appropriate way
  
  23/09/2002
    Riant
</pre>
<table border=0 width="100%">

 <tr>
  <td colspan=5>&nbsp;</td>
 </tr>
 <tr bgcolor="#e0e0e0">
  <td colspan=5 align=center><b>8 files modified</b></td>
 </tr>
 <tr>
  <td><b>Module</b></td>
  <td><b>File name</b></td>
  <td colspan=3><b>Version</b></td>
 </tr>
 <tr>
  <td><b>GtkRadiant</b></td>
  <td><code>docs/developer/CHANGES</code></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.255.2.107">1.255.2.107</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES.diff?r1=text&tr1=1.255.2.107&r2=text&tr2=1.255.2.108&f=h">&gt;&gt;&gt;</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/docs/developer/CHANGES?rev=1.255.2.108">1.255.2.108</a></td>
 </tr>
 <tr>
  <td><b>GtkRadiant</b></td>
  <td><code>radiant/brush.cpp</code></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.cpp?rev=1.30.2.6">1.30.2.6</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.cpp.diff?r1=text&tr1=1.30.2.6&r2=text&tr2=1.30.2.7&f=h">&gt;&gt;&gt;</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.cpp?rev=1.30.2.7">1.30.2.7</a></td>
 </tr>
 <tr>
  <td><b>GtkRadiant</b></td>
  <td><code>radiant/brush.h</code></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.h?rev=1.12">1.12</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.h.diff?r1=text&tr1=1.12&r2=text&tr2=1.12.2.1&f=h">&gt;&gt;&gt;</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/brush.h?rev=1.12.2.1">1.12.2.1</a></td>
 </tr>
 <tr>
  <td><b>GtkRadiant</b></td>
  <td><code>radiant/camwindow.cpp</code></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/camwindow.cpp?rev=1.17.6.8">1.17.6.8</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/camwindow.cpp.diff?r1=text&tr1=1.17.6.8&r2=text&tr2=1.17.6.9&f=h">&gt;&gt;&gt;</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/camwindow.cpp?rev=1.17.6.9">1.17.6.9</a></td>
 </tr>
 <tr>
  <td><b>GtkRadiant</b></td>
  <td><code>radiant/drag.cpp</code></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/drag.cpp?rev=1.7.2.2">1.7.2.2</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/drag.cpp.diff?r1=text&tr1=1.7.2.2&r2=text&tr2=1.7.2.3&f=h">&gt;&gt;&gt;</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/drag.cpp?rev=1.7.2.3">1.7.2.3</a></td>
 </tr>
 <tr>
  <td><b>GtkRadiant</b></td>
  <td><code>radiant/qe3.h</code></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/qe3.h?rev=1.49.2.7">1.49.2.7</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/qe3.h.diff?r1=text&tr1=1.49.2.7&r2=text&tr2=1.49.2.8&f=h">&gt;&gt;&gt;</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/qe3.h?rev=1.49.2.8">1.49.2.8</a></td>
 </tr>
 <tr>
  <td><b>GtkRadiant</b></td>
  <td><code>radiant/select.cpp</code></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.cpp?rev=1.19.2.4">1.19.2.4</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.cpp.diff?r1=text&tr1=1.19.2.4&r2=text&tr2=1.19.2.5&f=h">&gt;&gt;&gt;</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.cpp?rev=1.19.2.5">1.19.2.5</a></td>
 </tr>
 <tr>
  <td><b>GtkRadiant</b></td>
  <td><code>radiant/select.h</code></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.h?rev=1.8">1.8</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.h.diff?r1=text&tr1=1.8&r2=text&tr2=1.8.14.1&f=h">&gt;&gt;&gt;</a></td>
  <td><a href="http://zerowing.idsoftware.com/viewcvs/viewcvs.cgi/GtkRadiant/radiant/select.h?rev=1.8.14.1">1.8.14.1</a></td>
 </tr>

</table>

</body>
</html>

--10331603918474--