[aquaria] MiniMap gets cropped at 1280x1024

[Icy EyeG]

Indeed, but if I remember correctly, those black borders that show up at 5:4
resolutions exist in older versions of the game, including the HIB version
and 1.1.1

On Fri, Aug 19, 2011 at 12:36 PM, breversa <breversa at gmail.com> wrote:

> I confirm too : the minimap is displayed entirely again (in 1280x1024). :-)
>
> However, I still see narrow top and bottom black borders.
>
> 2011/8/18 Icy EyeG <icy.dearchild at gmail.com>:
> > Thank you for the patch, it works! I tested in both 4:3 and 5:4
> resolutions,
> > I can't test in 16:9 or 16:10 though.
> >
> > On Thu, Aug 18, 2011 at 9:49 PM, Andrew Church <
> achurch+aquaria at achurch.org>
> > wrote:
> >>
> >> >Hi all,
> >> >I just tried the latest build of Aquaria and the minimap at the bottom
> >> > left
> >> >corner of the screen gets cropped (ie, it's screen position is diverted
> >> > too
> >> >much to the bottom).
> >>
> >> Oops, this is probably my fault.  Patch below.
> >>
> >>  --Andrew Church
> >>    achurch at achurch.org
> >>    http://achurch.org/
> >>
> >> # HG changeset patch
> >> # User Andrew Church <achurch at achurch.org>
> >> # Date 1313667883 -32400
> >> # Node ID 929873f4768508f44273dc725df6f532fa717df1
> >> # Parent  88bd4f013e2e756e1b57891570f6c7980ea5025c
> >> Prevent the minimap from getting cut off on the bottom of a 1280x1024
> >> display.
> >>
> >> This patch fixes a bug in positioning the minimap which causes the
> >> bottom part of the minimap to be cut off when the display aspect ratio
> >> is less than 4:3 (e.g., 5:4 as on a 1280x1024 display).
> >>
> >> diff -r 88bd4f013e2e -r 929873f47685 Aquaria/MiniMapRender.cpp
> >> --- a/Aquaria/MiniMapRender.cpp Wed Aug 17 20:55:53 2011 +0900
> >> +++ b/Aquaria/MiniMapRender.cpp Thu Aug 18 20:44:43 2011 +0900
> >> @@ -243,7 +243,7 @@
> >>        RenderObject::onUpdate(dt);
> >>
> >>        position.x = core->getVirtualWidth() - core->getVirtualOffX() -
> >> getMiniMapWidth()/2;
> >> -       position.y = core->getVirtualHeight() - getMiniMapHeight()/2;
> >> +       position.y = 600 - getMiniMapHeight()/2;
> >>        position.z = 2.9;
> >>
> >>        waterSin += dt * (bitSizeLookupPeriod / (2*PI));
> >> _______________________________________________
> >> aquaria mailing list
> >> aquaria at icculus.org
> >> http://icculus.org/mailman/listinfo/aquaria
> >
> >
> > _______________________________________________
> > aquaria mailing list
> > aquaria at icculus.org
> > http://icculus.org/mailman/listinfo/aquaria
> >
> >
> _______________________________________________
> aquaria mailing list
> aquaria at icculus.org
> http://icculus.org/mailman/listinfo/aquaria
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://icculus.org/pipermail/aquaria/attachments/20110819/6dc361b3/attachment.htm>