[aquaria] Enable Windows compiling

Mikko Rasa tdb at tdb.fi
Sun Jun 6 02:23:32 EDT 2010


On 06.06.2010 04:00, Pontos wrote:
> On 6/5/2010 5:15 PM, Jordi Gutiérrez Hermoso wrote:
>> 2010/6/5 Pontos<daemonpontos at gmail.com>:
>>> Now, unrelated to Windows. Regarding what Jordi mentioned about the
>>> limits.h
>>> header, there is no need to add a new macro in cmakelists.txt given that
>>> BBGE_BUILD_UNIX already exists, is widely used, and does exactly the
>>> same
>>> thing you intended to achieve with the new macro.
>> Unix isn't Linux isn't MacOS X. I didn't check that macro. Is it
>> defined on MacOS X? From my reading of the CMakeLists.txt, it is.
>>
>> We really do need a Linux-specific macro because PATH_MAX is a very
>> system-dependent macro. It's not even POSIX, as far as I can tell.
 >>
 > My bad, i thought that BBGE_BUILD_UNIX was made to be used exclusively
 > for the Linux version, since there is another used with Mac.
 > In that case yeah, a new macro for <linux/limits.h>, but then <limits.h>
 > should be added for every other unix OS in case they need it.

I'm pretty sure it's POSIX.  I checked my copy of SUSv3, which states 
that PATH_MAX is to be found in <limits.h>.  It's quite common for 
standard headers to include implementation-specific heaaders that 
contain the actual definitions, so you can't tell which is the correct 
one just by finding the header with the definition.

-- 
Mikko Rasa "The DataBeaver"


More information about the aquaria mailing list